a few more bids goodbye #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2023
just need to fix the errors on this though before merging |
andytudhope
added a commit
to flashbots/suave-specs
that referenced
this pull request
Dec 22, 2023
Please see both flashbots/suave-geth#128 and flashbots/suave-geth#135 for further details.
|
lgtm. also in favor of both 1 + 2 |
metachris
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR follows up with further necessary changes after #128
📚 Thoughts
SubmitEthBlockBidToRelay->SubmitEthBlockToRelay?bids.soltobundles.sol. Was there a reason you did not do that @dmarzzz?